-
Notifications
You must be signed in to change notification settings - Fork 0
used marketplaceSDK instead of managementSDK for app related operations #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates app-related operations from using the managementSDK to the marketplaceSDK, aligning with the expected SDK for handling app installations and management operations. The changes include updating imports, function signatures, and test stubs to support the new SDK architecture.
Key changes:
- Replace managementSDK with marketplaceSDK for app installation and lifecycle operations
- Update imports from
@contentstack/management
to@contentstack/marketplace-sdk
- Refactor test files to remove duplicate stubs and improve test reliability
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/util/common-utils.ts | Updated app installation and update functions to use marketplaceSDK |
src/util/inquirer.ts | Modified app installation queries and added marketplace SDK support |
src/commands/app/*.ts | Updated command implementations to use marketplaceSDK for app operations |
src/strategies/*.ts | Updated uninstall strategies to support marketplaceSDK parameter passing |
test/unit/commands/app/*.ts | Removed duplicate test stubs and improved test setup |
package.json | Updated CLI utilities dependency version |
Comments suppressed due to low confidence (3)
test/unit/commands/app/update.test.ts:49
- This test has duplicate loader stubs - one was removed from line 48 but another remains. The remaining stub on line 49 should be sufficient.
sandbox.stub(cliux, "loader").callsFake(() => {});
test/unit/commands/app/uninstall.test.ts:113
- The test expects an error exit code but no longer validates it after removing the error assertion. Consider verifying the command still handles the error appropriately.
const { stdout } = await runCommand([
test/unit/commands/app/reinstall.test.ts:182
- The test changed from using mock.apps[0] to mock.apps[1] without explanation. This could indicate a test dependency issue or missing test data validation.
App: mock.apps[1].name,
Minor version bump 1.5.1 -> 1.6.0