added a delay to check failing test cases #2002
Conversation
| @@ -52,6 +52,10 @@ class AuthenticationHandler { | |||
| } | |||
|
|
|||
| async refreshAccessToken(error: any, maxRetryCount = 1): Promise<void> { | |||
| // Add delay to prevent burst requests and help diagnose GoCD pipeline failures | |||
| console.log('Adding delay before processing refreshAccessToken...'); | |||
There was a problem hiding this comment.
@naman-contentstack adding log will display in production as well, this wont be a right message to be printed in prod
There was a problem hiding this comment.
@naman-contentstack, can this be applied for the development environment only, since this will affect production users?
There was a problem hiding this comment.
Avoid using console logs.
Also, use environment-specific code with a logger or setTimeout
| @@ -52,6 +52,10 @@ class AuthenticationHandler { | |||
| } | |||
|
|
|||
| async refreshAccessToken(error: any, maxRetryCount = 1): Promise<void> { | |||
| // Add delay to prevent burst requests and help diagnose GoCD pipeline failures | |||
| console.log('Adding delay before processing refreshAccessToken...'); | |||
| await new Promise((resolve) => setTimeout(resolve, 2000)); // 2 second delay | |||
There was a problem hiding this comment.
I would suggest
if(process.env.environment === "development"){
// add code here
}
There was a problem hiding this comment.
await new Promise((resolve) => setTimeout(resolve, 2000));
can be - await new Promise((resolve) => setTimeout(resolve, process.env.DELAY || 2000));
in any case if we wants to increase or decrease the delay
There was a problem hiding this comment.
@naman-contentstack, can this be applied for the development environment only, since this will affect production users?
There was a problem hiding this comment.
Avoid using console logs.
Also, use environment-specific code with a logger or setTimeout
There was a problem hiding this comment.
@netrajpatel The issue was found in the prod e2e, we have discussed an action plan on the basis of env config so that the end user wont be affected
No description provided.