fix: pass pagination_token from entriesResponse to the recursive call in bulk unpublish getSyncEntries #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in bulk unpublish getSyncEntries
| @@ -228,10 +228,11 @@ async function getSyncEntries( | |||
| await bulkAction(stack, entriesResponse.items, bulkUnpublish, environment, locale, apiVersion, bulkPublishLimit, false); | |||
| } | |||
|
|
|||
| if (entriesResponse.items.length === 0) { | |||
| if (!entriesResponse.pagination_token) { | |||
There was a problem hiding this comment.
@MetodiYanev I have reviewed your changes — it looks good overall. Just a suggestion to update the exit condition with the latest logic:
if (entriesResponse.items.length === 0 && !entriesResponse.pagination_token)
This ensures the sync process only stops when there are truly no more items and no further pages (pagination_token).
Earlier, checking only items.length === 0 could cause premature exit even when more data was available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the getSyncEntries function where the recursive call to fetch additional pages of entries would always execute — even when pagination_token was null. As a result, the function would endlessly cycle through the first page of results without making progress.