Skip to content

Fix/dx 2973 export stack settings #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 19 commits into
base: development
Choose a base branch
from

Conversation

harshithad0703
Copy link
Contributor

No description provided.

@harshithad0703 harshithad0703 requested a review from a team as a code owner June 10, 2025 10:22
@harshithad0703 harshithad0703 changed the title Fix/dx 2973 export import stack settings Fix/dx 2973 export stack settings Jun 10, 2025
@harshithad0703 harshithad0703 requested review from Copilot and removed request for a team June 10, 2025 10:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the stack export feature by including branch names in export paths and adding a dedicated method to export stack settings, along with cleanup in rate-limit and audit modules.

  • Include branchName when resolving the export folder path for a stack
  • Add exportStackSettings() to write stack settings to settings.json
  • Remove unused imports and refine error logging in rate-limit and audit code

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/contentstack-export/src/export/modules/stack.ts Updated stackFolderPath to include branchName and added exportStackSettings()
packages/contentstack-config/src/utils/rate-limit-handler.ts Removed unused formatError import and cleaned up error logging
packages/contentstack-config/src/commands/config/set/rate-limit.ts Imported formatError and revised CLI error messages in the set-rate-limit command
packages/contentstack-audit/src/modules/entries.ts Refactored title sanitization logic and changed removeEmojiAndImages implementation
.talismanrc Updated checksum for package-lock.json ignore entry
Comments suppressed due to low confidence (2)

packages/contentstack-config/src/commands/config/set/rate-limit.ts:87

  • [nitpick] This duplicates the error output and may log an object directly. Consolidate messages—use formatError(error) or error.message consistently and remove the extra cliux.error(error).
cliux.error(error);

packages/contentstack-audit/src/modules/entries.ts:845

  • The removal of optional chaining (?.) means removeEmojiAndImages will throw on undefined input. Restore safety by reintroducing str?.replace or validate str first.
return str.replace(

aman19K
aman19K previously approved these changes Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants