-
Notifications
You must be signed in to change notification settings - Fork 15
Fix/dx 2973 export stack settings #1960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Fix/dx 2973 export stack settings #1960
Conversation
… related functionality for clarity
…-import-stack-settings
…port-import-stack-settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the stack export feature by including branch names in export paths and adding a dedicated method to export stack settings, along with cleanup in rate-limit and audit modules.
- Include
branchName
when resolving the export folder path for a stack - Add
exportStackSettings()
to write stack settings tosettings.json
- Remove unused imports and refine error logging in rate-limit and audit code
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
packages/contentstack-export/src/export/modules/stack.ts | Updated stackFolderPath to include branchName and added exportStackSettings() |
packages/contentstack-config/src/utils/rate-limit-handler.ts | Removed unused formatError import and cleaned up error logging |
packages/contentstack-config/src/commands/config/set/rate-limit.ts | Imported formatError and revised CLI error messages in the set-rate-limit command |
packages/contentstack-audit/src/modules/entries.ts | Refactored title sanitization logic and changed removeEmojiAndImages implementation |
.talismanrc | Updated checksum for package-lock.json ignore entry |
Comments suppressed due to low confidence (2)
packages/contentstack-config/src/commands/config/set/rate-limit.ts:87
- [nitpick] This duplicates the error output and may log an object directly. Consolidate messages—use
formatError(error)
orerror.message
consistently and remove the extracliux.error(error)
.
cliux.error(error);
packages/contentstack-audit/src/modules/entries.ts:845
- The removal of optional chaining (
?.
) meansremoveEmojiAndImages
will throw onundefined
input. Restore safety by reintroducingstr?.replace
or validatestr
first.
return str.replace(
No description provided.