fix: to_archive does not store resources associated with ingredients #1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextrnnn
force-pushed
the
alextrnnn/fix-archive
branch
from
1355292 to
7782d90
Compare
|
@alextrnnn Seems there is a conflict to resolve. |
tmathern
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
LGTM, but please wait for a review from @gpeacock or @mauricefisher64 regarding the validity of us supporting this scenario. Thanks.
ok-nick
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Scenario (detected by unit test):
This scenario would result in a ResourceNotFound error.
Modifications to_archive/from_archive to add/read the ingredient's resource files to/from the zip have been added to resolve this error.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.