feat: add Reader::manifest_source
#1150
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok-nick
changed the title
Reader::manifest_locationReader::manifest_location and `c2pa::manifest_locations_from_stream)
ok-nick
changed the title
Reader::manifest_location and `c2pa::manifest_locations_from_stream)Reader::manifest_location and c2pa::manifest_locations_from_stream
tmathern
reviewed
Jun 9, 2025
|
Please do not proceed with these changes in the Rust SDK until I've had a chance to think about it. Right now I would not approve. |
ok-nick
changed the title
Reader::manifest_location and c2pa::manifest_locations_from_streamReader::manifest_location
| /// The manifest is stored remotely. | ||
| Remote, | ||
| /// The manifest is stored separately in a sidecar. | ||
| Sidecar, |
There was a problem hiding this comment.
Where is Sidecar used?
There was a problem hiding this comment.
I should clarify the docs here, Sidecar is returned when the manifest is passed explicitly via a method such as from_manifest_data_and_stream. If there's a better name to describe this variant let me know.
ok-nick
changed the title
Reader::manifest_locationReader::manifest_source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Implements:
Store::source(low-level)Reader::manifest_source(high-level)which returns the source of the manifest used during reading:
ManifestSource::EmbeddedManifestSource::RemoteManifestSource::SidecarA manifest source is considered a sidecar if the manifest bytes were given explicitly, rather than obtained via embedded or remote (XMP).
These APIs are also implemented for the C bindings.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.