Skip to content

Conversation

ArtiomDivak
Copy link
Collaborator

@ArtiomDivak ArtiomDivak commented Aug 12, 2025

"Add documentation for adjusting OOM scores in nested containers

This adds comprehensive documentation on how to customize OOM score
adjustment for nested containers running inside QM, including:

  • Step-by-step configuration of nested container Quadlet files
  • QM drop-in configuration for required capabilities
  • Verification process using podman-system-generator
  • Testing procedures with expected OOM score values

The documentation shows how to set different OOM priorities for
nested containers (1000 vs 100) to control OOM killer behavior.

Closes #899

Copy link
Contributor

sourcery-ai bot commented Aug 12, 2025

Reviewer's Guide

Adds a new documentation section in README.md detailing how to override QM container attributes via systemd drop-in files, complete with setup steps, an example use case, verification procedures, and best-practice notes.

File-Level Changes

Change Details Files
Introduce 'Overwriting QM attributes' documentation section
  • Define drop-in directory path and file naming convention
  • Outline steps to create directory and custom .conf file
  • Explain persistence across QM updates
README.md
Provide example for removing device access
  • Show drop-in file content to clear AddDevice entries
  • Contrast default AddDevice settings with overrides
README.md
Add verification procedure for drop-in overrides
  • Include dry-run command for podman-system-generator
  • Advise checking generated ExecStart output
  • Explain service reload steps
README.md
List important notes on drop-in file ordering and naming
  • Emphasize alphabetical processing of drop-in files
  • Recommend descriptive filenames for order control
  • Advise verifying changes before applying
README.md

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArtiomDivak - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dougsland
Copy link
Member

We are looking to document OOMScoreAdjust for nested containers from #893, please update your PR to document 893.

@ArtiomDivak ArtiomDivak force-pushed the issue-899 branch 2 times, most recently from f8cd299 to d44bd25 Compare August 18, 2025 14:30
@ArtiomDivak ArtiomDivak requested a review from Yarboa August 19, 2025 05:18
@Yarboa
Copy link
Collaborator

Yarboa commented Aug 20, 2025

/packit test --identifier kvm-tier-0

This adds comprehensive documentation on how to customize QM container
configuration using systemd drop-in files without modifying the original
qm.container file. Includes practical examples and verification steps.

Closes containers#899

Signed-off-by: Artiom Divak <adivak@redhat.com>
@Yarboa
Copy link
Collaborator

Yarboa commented Aug 21, 2025

@ArtiomDivak please take a look at aib test
https://artifacts.dev.testing-farm.io/0dbe8127-fd62-47e1-a585-613fcbcd9053/

Can you analyze it?

There is another fix need to be rebased once it is merge

@Yarboa
Copy link
Collaborator

Yarboa commented Aug 21, 2025

@ArtiomDivak please take a look at aib test https://artifacts.dev.testing-farm.io/0dbe8127-fd62-47e1-a585-613fcbcd9053/

Can you analyze it?

There is another fix need to be rebased once it is merge

looking at it on #916

@Yarboa Yarboa merged commit f99385f into containers:main Aug 21, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document how to change OOMScoreAdjust for nested containers

3 participants