Exclude symlink from pre-commit end-of-file-fixer #24490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
Luap99
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
LGTM
but as you pointed should we then add https://github.com/pre-commit/pre-commit-hooks/blob/main/README.md#destroyed-symlinks to the list of checks as well to prevent this issue on new/other links so we avoid broken links
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: l0rd, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
also minor nit in case you repush |
Git on Windows clones the symlink `test/python/requirements.txt` as a regular file. That's not a big deal except that `pre-commit`, executed by `winmake.ps1 lint`, complains because there is no new line at end of the file. To fix `winmake.ps1 lint` we exclude the symlink in `pre-commit` hook `end-of-file-fixer` configuration. Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
l0rd
force-pushed
the
pre-commit-fix-for-windows
branch
from
887aa7b to
d49497c
Compare
|
yeah, /lgtm |
openshift-merge-bot
bot
merged commit e3770f5
into
containers:main
34 of 38 checks passed
l0rd
changed the title
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git on Windows clones the symlink
test/python/requirements.txtas a regular file. That's not a big deal except thatpre-commit, executed bywinmake.ps1 lint, complains because there is no new line at end of the file.To fix
winmake.ps1 lintwe exclude the symlink inpre-commithookend-of-file-fixerconfiguration.Does this PR introduce a user-facing change?