libpod: use pasta Setup() over Setup2() #24417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup2() calls Setup() so they are both the same thing, the idea was to keep Setup2() around in c/common for a bit to avoid breaking changes during our regular vendoring. Now just use Setup() so we can get rid of Setup2() in c/common. containers/common@a7415c3 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Luap99
added a commit
to Luap99/common
that referenced
this pull request
Oct 30, 2024
This was just added as alias to allow vendoring without having to fix all callers at the same time. These are the PRs that updat the callers: containers/podman#24417 containers/buildah#5724 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added a commit
to Luap99/common
that referenced
this pull request
Oct 30, 2024
This was just added as alias to allow vendoring without having to fix all callers at the same time. These are the PRs that update the callers: containers/podman#24417 containers/buildah#5724 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added
the
No New Tests
|
LGTM |
|
/lgtm |
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup2() calls Setup() so they are both the same thing, the idea was to keep Setup2() around in c/common for a bit to avoid breaking changes during our regular vendoring. Now just use Setup() so we can get rid of Setup2() in c/common.
containers/common@a7415c3
Does this PR introduce a user-facing change?