Skip to content

logformatter: add cleanup tracer log link #24411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Oct 29, 2024

I had a few cases where this is super handy in CI and if I can access the link without one extra click it safes me some time and hopefully makes it more discoverable for other to see how useful it can be sometimes.

Does this PR introduce a user-facing change?

None

@Luap99 Luap99 added the No New Tests Allow PR to proceed without adding regression tests label Oct 29, 2024
Copy link
Contributor

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
@Luap99
Copy link
Member Author

Luap99 commented Oct 29, 2024

@edsantiago PTAL, not sure if this is right but I guess will find out soon enough when I look at logs here

@edsantiago
Copy link
Member

/lgtm

/hold
(Hold is to allow time to verify the resulting logs)

Good to hear that your tracer logs are proving useful!

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Oct 29, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@edsantiago
Copy link
Member

/lgtm

Shame on me for not even bothering to run the script. It passes syntax check now.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@Luap99
Copy link
Member Author

Luap99 commented Oct 29, 2024

Shame on me for being unable to use copy+paste correctly :)

I had a few cases where this is super handy in CI and if I can access the
link without one extra click it safes me some time and hopefully makes
it more discoverable for other to see how useful it can be sometimes.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@Luap99
Copy link
Member Author

Luap99 commented Oct 29, 2024

Ok link was not working, I think because it was missing the extra /artifact in the URL like used for the remote server

@edsantiago
Copy link
Member

I had not verified that, but just did so (by cutting-pasting on an existing podman-server.log link).

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@edsantiago
Copy link
Member

Working now

@edsantiago
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a2b76a8 into containers:main Oct 29, 2024
85 checks passed
@Luap99 Luap99 deleted the logformatter branch October 29, 2024 20:09
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jan 28, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants