NEWS: tag 1.24 #1875

giuseppe · 2025-09-09T12:51:17Z

Summary by Sourcery

Implement unified handling of masked directory mounts for CRIU via a shared empty directory mechanism, introduce a utility to manage this directory, improve safety around state_root access, and fix the netlink buffer sizing in network setup

Enhancements:

Consolidate masked_paths handling in CRIU checkpoint and restore to support both file and directory mounts using a shared empty directory
Extract and reuse get_shared_empty_directory_path for creating and caching the shared empty directory
Add null checks around container context when accessing state_root in state directory, socket, device, and seccomp functions
Adjust netlink message buffer size in network configuration to use nlmsgerr structure

sourcery-ai · 2025-09-09T12:51:27Z

Reviewer's Guide

This PR tags the 1.24 release in NEWS and implements a major refactor of CRIU masked-path handling by introducing a shared empty-directory mount, centralizes the empty-directory path logic into a new helper, adds defensive null-checks for container context, corrects a network buffer size, and updates the public API accordingly.

File-Level Changes

Change	Details	Files
Enhanced CRIU masked-path checkpoint/restore logic with shared empty-directory support	Replaced single loop over masked_paths with branching for directories vs files Mount one shared empty directory and bind-mask all dirs against it Retained per-file mounts for regular masked files	`src/libcrun/criu.c`
Centralized empty-directory path creation into helper function	Extracted directory path creation and ensure-directory calls into get_shared_empty_directory_path Removed redundant logic in get_shared_empty_dir_cached	`src/libcrun/linux.c` `src/libcrun/status.c` `src/libcrun/status.h`
Added defensive null-context checks when opening state and rundir	Guard calls to libcrun_get_state_directory with context existence Guard calls to open_rundir_dirfd with context existence	`src/libcrun/linux.c` `src/libcrun/seccomp.c`
Corrected network configuration buffer sizing	Changed local buffer from size of ifinfomsg to size of nlmsgerr	`src/libcrun/linux.c`
Updated NEWS for 1.24 release	Added NEWS entry for version 1.24	`NEWS`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

packit-as-a-service · 2025-09-09T13:09:38Z

TMT tests failed. @containers/packit-build please check.

giuseppe · 2025-09-09T13:46:47Z

looks like there is a regression with CRIU, need to investigate it first

giuseppe · 2025-09-09T13:49:07Z

@sohankunkerkar it seems like the bind mount optimization is causing this issue

sohankunkerkar · 2025-09-09T17:57:13Z

src/libcrun/criu.c

-        }
-    }
+  {
+    cleanup_free char *empty_dir_path = NULL;


We should create a helper function to dedup this logic.

could you check the new version?

sohankunkerkar

CI is green now! one nit but overall LGTM

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

commit 4004e5b introduced the regression. It is not part of any release. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

sohankunkerkar · 2025-09-09T19:20:15Z

/lgtm

sourcery-ai bot approved these changes Sep 9, 2025

View reviewed changes

giuseppe marked this pull request as draft September 9, 2025 13:16

giuseppe force-pushed the tag-1.24 branch from bb3f235 to 57e1d13 Compare September 9, 2025 13:21

giuseppe force-pushed the tag-1.24 branch 2 times, most recently from b1c6dd5 to 0020f32 Compare September 9, 2025 17:03

sohankunkerkar reviewed Sep 9, 2025

View reviewed changes

giuseppe marked this pull request as ready for review September 9, 2025 18:25

sourcery-ai bot approved these changes Sep 9, 2025

View reviewed changes

giuseppe added 3 commits September 9, 2025 20:30

criu: checkpoint correctly the shared empty directory path

d8a88c0

commit 4004e5b introduced the regression. It is not part of any release. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

linux: fix array bounds warning in libcrun_configure_network

676c2c1

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

NEWS: tag 1.24

5469320

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

giuseppe force-pushed the tag-1.24 branch from 0020f32 to 5469320 Compare September 9, 2025 18:30

giuseppe merged commit 6f0a3c5 into containers:main Sep 9, 2025
63 of 64 checks passed

NEWS: tag 1.24 #1875

NEWS: tag 1.24 #1875

Uh oh!

Conversation

giuseppe commented Sep 9, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

packit-as-a-service bot commented Sep 9, 2025

Uh oh!

giuseppe commented Sep 9, 2025

Uh oh!

giuseppe commented Sep 9, 2025

Uh oh!

sohankunkerkar Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

giuseppe Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

sohankunkerkar left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sohankunkerkar commented Sep 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

giuseppe commented Sep 9, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Sep 9, 2025 •

edited

Loading