container: add missing crun_make_error

[eriksjolund]

It looks like the errors are missing.

I reused the error message from here:

crun/src/libcrun/container.c

Line 1668 in 92977c0

return crun_make_error (err, ret, "exec container process failed with handler as `%s`", entrypoint_args->custom_handler->vtable->name);

Feel free to suggest another error message if it's bad to have exactly the same
error message.

Summary by Sourcery

Add missing error creation calls to return descriptive errors for environment clearing and process execution failures

Bug Fixes:

• Wrap clearenv failure return with crun_make_error to include error message
• Wrap exec process failure return with crun_make_error to include handler name in error message

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enhances error reporting in exec_process_entrypoint by replacing raw returns with structured crun_make_error calls, ensuring consistent and informative error propagation for clearenv and exec failures.

Class diagram for updated error handling in exec_process_entrypoint

classDiagram
    class exec_process_entrypoint {
        +int clearenv()
        +int crun_make_error(err, errno, message)
        +int exec_path
        +int process->args
        +custom_handler->vtable->name
    }
    exec_process_entrypoint --> crun_make_error : uses for error reporting
    exec_process_entrypoint --> clearenv : calls
    exec_process_entrypoint --> exec_path : executes
    exec_process_entrypoint --> process : accesses args
    exec_process_entrypoint --> custom_handler : accesses vtable->name

Loading

File-Level Changes

Change	Details	Files
Improve error handling for clearenv failure	Replaced bare return of clearenv error code Added crun_make_error with errno and "clearenv" context	src/libcrun/container.c
Improve error handling for exec container process failure	Replaced bare return of exec handler error code Added crun_make_error with negated return code and format string including handler name	src/libcrun/container.c

Possibly linked issues

• #0: The PR adds missing crun_make_error calls, ensuring negative error codes are correctly propagated, resolving the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[packit-as-a-service]

TMT tests failed. @containers/packit-build please check.

[giuseppe]

LGTM