Skip to content

Conversation

flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Sep 5, 2025

Reverts #1768

Summary by Sourcery

Restore the default systemd sub-cgroup behavior by returning "container" when no subgroup is specified and update documentation to match the restored defaults.

Bug Fixes:

  • Reinstate default sub-cgroup creation by returning "container" instead of NULL in find_systemd_subgroup.

Documentation:

  • Update man page and markdown to document default SUBGROUP as "container" on cgroup v2 and empty on cgroup v1.

Copy link

sourcery-ai bot commented Sep 5, 2025

Reviewer's Guide

This PR reverts the previous change that disabled default sub-cgroup creation by restoring the fallback to “container” in the code and updating the man pages to document the default behavior and usage across cgroup v1 and v2.

File-Level Changes

Change Details Files
Restore default systemd sub-cgroup creation logic
  • Changed find_systemd_subgroup() fallback from NULL to “container”
  • Reintroduced default SUBGROUP when no annotation is provided
src/libcrun/cgroup-systemd.c
Update documentation for run.oci.systemd.subgroup option
  • Revised description to explain overriding and default behavior
  • Added default values for cgroup v2 (container) and v1 (empty string)
  • Updated usage examples to match restored defaults
  • Removed outdated paragraphs about no sub-cgroup by default
crun.1
crun.1.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@flouthoc
Copy link
Collaborator Author

flouthoc commented Sep 5, 2025

Oops I created a revert PR using github UI it doesn't add sign-offs. @giuseppe Might wanna do this with manual PR ?

@flouthoc flouthoc closed this Sep 5, 2025
Copy link

TMT tests failed. @containers/packit-build please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant