intelrdt: add support for EnableMonitoring #1866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideIntroduce optional monitoring group management in Intel RDT by extending the resctrl API, integrating an enable_monitoring flag into libcrun workflows, and removing legacy status fields. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
support-rdt-monitoring
branch
3 times, most recently
from
c83b1ed to
456f6e6
Compare
|
tested on a machine with Intel RDT support and it works as expected. Ready for review |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Refactor repeated enable_monitoring checks into a helper to reduce nesting and improve readability in apply/destroy logic.
- Removing the intelrdt field from the status JSON may break backward compatibility—consider versioning or migrating existing state.
- Current monitoring cleanup swallows errors; consider logging or aggregating errors instead of silently discarding them.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Refactor repeated enable_monitoring checks into a helper to reduce nesting and improve readability in apply/destroy logic.
- Removing the intelrdt field from the status JSON may break backward compatibility—consider versioning or migrating existing state.
- Current monitoring cleanup swallows errors; consider logging or aggregating errors instead of silently discarding them.
## Individual Comments
### Comment 1
<location> `src/libcrun/intelrdt.c:317` </location>
<code_context>
+ if (UNLIKELY (ret < 0))
+ return ret;
+
+ if (monitoring_name)
+ {
+ ret = append_paths (&monitoring_path, err, INTEL_RDT_MOUNT_POINT, name, MON_GROUPS, monitoring_name, TASKS_FILE, NULL);
+ if (UNLIKELY (ret < 0))
+ return ret;
+
+ ret = write_file (monitoring_path, pid_str, len, err);
+ if (UNLIKELY (ret < 0))
+ return ret;
</code_context>
<issue_to_address>
No error handling for partial success in moving task to monitoring group.
If writing to the monitoring group fails after success with the main group, the process state may be inconsistent. Please consider implementing rollback or enhanced error reporting for this scenario.
</issue_to_address>
### Comment 2
<location> `src/libcrun/linux.c:6045` </location>
<code_context>
return 0;
fail:
+ if (has_monitoring)
+ {
+ libcrun_error_t tmp_err = NULL;
+ int tmp_ret;
+
+ tmp_ret = resctl_destroy_monitoring_group (name, ctr_name, &tmp_err);
+ if (tmp_ret < 0)
+ crun_error_release (&tmp_err);
</code_context>
<issue_to_address>
Error from resctl_destroy_monitoring_group is ignored.
If monitoring group cleanup fails, resources may not be released. Please log the error or propagate it to ensure failures are visible.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
tmp_ret = resctl_destroy_monitoring_group (name, ctr_name, &tmp_err);
if (tmp_ret < 0)
crun_error_release (&tmp_err);
=======
tmp_ret = resctl_destroy_monitoring_group (name, ctr_name, &tmp_err);
if (tmp_ret < 0)
{
crun_error_log (&tmp_err);
if (err && *err == NULL)
*err = tmp_err;
else
crun_error_release (&tmp_err);
}
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+317
to
+323
| if (monitoring_name) | ||
| { | ||
| ret = append_paths (&monitoring_path, err, INTEL_RDT_MOUNT_POINT, name, MON_GROUPS, monitoring_name, TASKS_FILE, NULL); | ||
| if (UNLIKELY (ret < 0)) | ||
| return ret; | ||
|
|
||
| ret = write_file (monitoring_path, pid_str, len, err); |
There was a problem hiding this comment.
issue: No error handling for partial success in moving task to monitoring group.
If writing to the monitoring group fails after success with the main group, the process state may be inconsistent. Please consider implementing rollback or enhanced error reporting for this scenario.
Comment on lines
+6050
to
+6052
| tmp_ret = resctl_destroy_monitoring_group (name, ctr_name, &tmp_err); | ||
| if (tmp_ret < 0) | ||
| crun_error_release (&tmp_err); |
There was a problem hiding this comment.
suggestion (bug_risk): Error from resctl_destroy_monitoring_group is ignored.
If monitoring group cleanup fails, resources may not be released. Please log the error or propagate it to ensure failures are visible.
Suggested change
| tmp_ret = resctl_destroy_monitoring_group (name, ctr_name, &tmp_err); | |
| if (tmp_ret < 0) | |
| crun_error_release (&tmp_err); | |
| tmp_ret = resctl_destroy_monitoring_group (name, ctr_name, &tmp_err); | |
| if (tmp_ret < 0) | |
| { | |
| crun_error_log (&tmp_err); | |
| if (err && *err == NULL) | |
| *err = tmp_err; | |
| else | |
| crun_error_release (&tmp_err); | |
| } |
giuseppe
force-pushed
the
support-rdt-monitoring
branch
2 times, most recently
from
6cd4a53 to
0b85287
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
support-rdt-monitoring
branch
from
0b85287 to
dfdcf77
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completely untested, need access to the hardware, leaving as a Draft until then.
Summary by Sourcery
Enable tracking of monitoring tasks under Intel RDT by adding mon_groups support and wiring enable_monitoring through resctrl operations and container lifecycle
New Features:
Enhancements: