-
Notifications
You must be signed in to change notification settings - Fork 377
contrib: format contrib files #1863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Reviewer's GuideThis PR applies consistent formatting to contrib C source files—restructuring the error macro, standardizing whitespace around function calls and operators, trimming trailing spaces, and updating the Makefile.am clang-format target to include the contrib directory. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The error macro parameter named
errno
shadows the global errno variable—consider renaming it (e.g.errnum
) to avoid confusion. - Manual spacing adjustments (e.g.
if (! errno)
vsif (!errno)
) are inconsistent—either align with the existing style guide or drive these changes through a shared clang-format configuration. - The updated
Makefile.am
now includescontrib
in the clang-format target; you may want to runmake format
on all contrib sources to ensure full consistency.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The error macro parameter named `errno` shadows the global errno variable—consider renaming it (e.g. `errnum`) to avoid confusion.
- Manual spacing adjustments (e.g. `if (! errno)` vs `if (!errno)`) are inconsistent—either align with the existing style guide or drive these changes through a shared clang-format configuration.
- The updated `Makefile.am` now includes `contrib` in the clang-format target; you may want to run `make format` on all contrib sources to ensure full consistency.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary by Sourcery
Reformat contrib C files for consistent code style and extend clang-format target to include contrib directory
Enhancements:
Build: