Skip to content

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Aug 29, 2025

Summary by Sourcery

Reformat contrib C files for consistent code style and extend clang-format target to include contrib directory

Enhancements:

  • Apply consistent spacing and indentation in contrib/terminal-receiver, contrib/notify-socket-server, and contrib/seccomp-receiver C sources

Build:

  • Include contrib directory in Makefile clang-format target

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Copy link

sourcery-ai bot commented Aug 29, 2025

Reviewer's Guide

This PR applies consistent formatting to contrib C source files—restructuring the error macro, standardizing whitespace around function calls and operators, trimming trailing spaces, and updating the Makefile.am clang-format target to include the contrib directory.

File-Level Changes

Change Details Files
Reformatted the error macro definitions
  • Expanded and indented the do/while block uniformly
  • Standardized spacing around errno checks and exit calls
contrib/terminal-receiver/terminal-receiver.c
contrib/notify-socket-server/notify-socket-server.c
contrib/seccomp-receiver/seccomp-receiver.c
Standardized whitespace around function calls and operators
  • Added spaces inside parentheses for calls to write, read, printf, fcntl, etc.
  • Inserted spaces around bitwise OR operators in socket and recvmsg flags
contrib/terminal-receiver/terminal-receiver.c
contrib/notify-socket-server/notify-socket-server.c
Removed trailing whitespace and aligned indentation
  • Deleted superfluous spaces and blank lines
  • Aligned braces and code blocks to match style guidelines
contrib/terminal-receiver/terminal-receiver.c
contrib/seccomp-receiver/seccomp-receiver.c
Extended clang-format target in Makefile.am
  • Included contrib directory in git ls-files for C/headers formatting
Makefile.am

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The error macro parameter named errno shadows the global errno variable—consider renaming it (e.g. errnum) to avoid confusion.
  • Manual spacing adjustments (e.g. if (! errno) vs if (!errno)) are inconsistent—either align with the existing style guide or drive these changes through a shared clang-format configuration.
  • The updated Makefile.am now includes contrib in the clang-format target; you may want to run make format on all contrib sources to ensure full consistency.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The error macro parameter named `errno` shadows the global errno variable—consider renaming it (e.g. `errnum`) to avoid confusion.
- Manual spacing adjustments (e.g. `if (! errno)` vs `if (!errno)`) are inconsistent—either align with the existing style guide or drive these changes through a shared clang-format configuration.
- The updated `Makefile.am` now includes `contrib` in the clang-format target; you may want to run `make format` on all contrib sources to ensure full consistency.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flouthoc flouthoc merged commit c630cb6 into containers:main Sep 2, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants