Skip to content

Conversation

fabbione
Copy link
Contributor

@fabbione fabbione commented Aug 20, 2025

Summary by Sourcery

New Features:

  • Introduce debug parameter to run_and_get_output helper to enable passing --debug to crun invocation

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
Copy link

sourcery-ai bot commented Aug 20, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This change enhances the test utility by introducing a debug flag to the run_and_get_output helper, allowing tests to inject a --debug switch into the crun invocation when needed.

File-Level Changes

Change Details Files
Introduce debug flag to run_and_get_output helper
  • Rename debug_on_error parameter to debug
  • Add debug_arg conditional list when debug is true
  • Include debug_arg into the crun argument construction
tests/tests_utils.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@fabbione fabbione changed the title Tests add debug output opt Tests: add debug output opt Aug 20, 2025
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@fabbione
Copy link
Contributor Author

the failures in fedora-eln are related to conflicting rpm packages. Not related to this change.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit f7e1211 into containers:main Aug 26, 2025
42 of 47 checks passed
@fabbione fabbione deleted the tests-add-debug-output-opt branch September 1, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants