Skip to content

Fix static analysis reports #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 15, 2024
Merged

Fix static analysis reports #1605

merged 4 commits into from
Nov 15, 2024

Conversation

giuseppe
Copy link
Member

@giuseppe
Copy link
Member Author

@PavlNekrasov FYI

@giuseppe giuseppe force-pushed the fix-static-analysis-reports branch from e17db49 to 42d408e Compare November 14, 2024 10:41
@giuseppe
src: run make clang-format
1ae190b 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
cgroup: drop unuseful check
2525752 
subsystem can't be NULL, so remove the check.

Closes: containers#1602

Reported-by: Pavel Nekrasov <p.nekrasov@fobos-nt.ru>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
linux: add check before deref
10b2146 
check that mount_fds is not NULL before accessing it.  A similar check
exists later in the code.

Closes: containers#1603

Reported-by: Pavel Nekrasov <p.nekrasov@fobos-nt.ru>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the fix-static-analysis-reports branch from 42d408e to ff04a9d Compare November 14, 2024 14:11
@giuseppe
crun: check for integer overflow
85d4db3 
validate that the stroll returned value can fit into an integer.

Closes: containers#1604

Reported-by: Pavel Nekrasov <p.nekrasov@fobos-nt.ru>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the fix-static-analysis-reports branch from ff04a9d to 85d4db3 Compare November 14, 2024 17:50
@giuseppe
Copy link
Member Author

@flouthoc @kolyshkin PTAL

@giuseppe giuseppe mentioned this pull request Nov 15, 2024
Merged
flouthoc
flouthoc approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flouthoc flouthoc merged commit 8399801 into containers:main Nov 15, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flouthoc flouthoc flouthoc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giuseppe @flouthoc