linux: copy map_file before tokenizing in uidgidmap_helper #1587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconz2
force-pushed
the
uidgid-xstrdup
branch
from
92dcaa8 to
75aa509
Compare
giuseppe
requested changes
Oct 24, 2024
libcrun_set_usernamespace passes uid_map/gid_map to uidgidmap_helper which tokenizes it to pass as process args. But if the helper isn't available, the fallback (when host_uid != 0) reuses this tokenized string and tries writing it to /proc/pid/gid_map which fails with EINVAL Signed-off-by: Andrew Consroe <aconz2@gmail.com>
aconz2
force-pushed
the
uidgid-xstrdup
branch
from
75aa509 to
3647eca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libcrun_set_usernamespace passes uid_map/gid_map to uidgidmap_helper which tokenizes it to pass as process args. But if the helper isn't available, the fallback (when host_uid != 0) reuses this tokenized string and tries writing it to /proc/pid/gid_map which fails with EINVAL
closes #1585