Skip to content

Conversation

sedwards
Copy link

Reduce the diff a little bit without hopefully adding too much to the Linux side

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@sedwards sedwards force-pushed the macos_build branch 3 times, most recently from 87b36d8 to 71c83d7 Compare October 22, 2024 20:01
Signed-off-by: Steven Edwards <sedwards@cisco.com>
@sedwards
Copy link
Author

Sorry for the repeated force push, for some strange reason some of the rpm builds were failing even though none of the checks should have caused an issue.

I finally got all of the checks to pass except there was a formatting issue that I didn't know about with clang-format so I ran it and it seems to have reformatted a few other things in the tree.

Let me know if you want me to filter out those formatting changes and resubmit. Thanks!

@giuseppe
Copy link
Member

giuseppe commented Oct 24, 2024

thanks for opening a PR!

Won't the build fail when these headers are missing? Otherwise if they are not needed and the build succeeds, we can drop the include's.

If I can ask, what platform are you targetting for the port?

@giuseppe
Copy link
Member

giuseppe commented Dec 6, 2024

got no feedback, I am closing it. Please reopen if you are still working on it

@giuseppe giuseppe closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants