cgroup, systemd: add support for IODeviceWeight #1579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
giuseppe
force-pushed
the
support-io-weight-device
branch
from
e00739b to
0319f1b
Compare
|
podman system tests failed. @containers/packit-build please check. |
giuseppe
force-pushed
the
support-io-weight-device
branch
from
0319f1b to
0a571fa
Compare
giuseppe
force-pushed
the
support-io-weight-device
branch
from
0a571fa to
7d24aa3
Compare
giuseppe
force-pushed
the
support-io-weight-device
branch
2 times, most recently
from
e86b5c4 to
30fda6b
Compare
it is a preparation for the next commit Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
If the "io.(bfq)weight" is specified in the format "$DEVICE $VALUE", pass the information to systemd using IODeviceWeight instead of IOWeight, that is only used for the default value. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
writing to io.weight, at least, fails with EINVAL the write attempts with multiple lines. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
support-io-weight-device
branch
from
30fda6b to
c4a65aa
Compare
|
@flouthoc can you please take another look and merge if it is good for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up for #1574