Skip to content

Conversation

sky-big
Copy link
Contributor

@sky-big sky-big commented Oct 12, 2024

oci add duplicate namespace detection。

original pr: #1564

@sky-big
Copy link
Contributor Author

sky-big commented Oct 12, 2024

@giuseppe please help reveiew。

@giuseppe
Copy link
Member

please use a real name for your Signed-off-by line, run make clang-format and amend the changes.

@sky-big
Copy link
Contributor Author

sky-big commented Oct 12, 2024

please use a real name for your Signed-off-by line, run make clang-format and amend the changes.

done

@giuseppe
Copy link
Member

thanks, the DCO test is still failing. I think you need to change the author field in the commit as well. You can use git commit --amend --author="Xingwen Xu <sky_big@yeah.net>"

Signed-off-by: Xingwen Xu <sky_big@yeah.net>
@sky-big
Copy link
Contributor Author

sky-big commented Oct 14, 2024

thanks, the DCO test is still failing. I think you need to change the author field in the commit as well. You can use git commit --amend --author="Xingwen Xu <sky_big@yeah.net>"

ok, done

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit 53cd1c1 into containers:main Oct 14, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants