Skip to content

Conversation

saschagrunert
Copy link
Member

We should log only after the context setup, otherwise we may use the wrong format or target.

We should log only after the context setup, otherwise we may use the
wrong format or target.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@kwilczynski
Copy link
Member

/approve
/lgtm

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link

podman system tests failed. @containers/packit-build please check.

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link

podman system tests failed. @containers/packit-build please check.

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit e9a05a8 into containers:main Sep 2, 2024
34 of 56 checks passed
@saschagrunert saschagrunert deleted the log-context branch September 2, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants