Skip to content

Conversation

@scpeters
Copy link
Contributor

@scpeters scpeters commented Oct 1, 2025

Adapt the fix for DelNetworkList from #1072 to DelNetwork and update test.

Adapt fix for DelNetworkList to DelNetwork and update test.

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
@scpeters scpeters force-pushed the invalidcache_delnetwork branch from c1a440b to 36b1672 Compare October 1, 2025 06:54
Copy link
Member

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tests are failing; can you take a look?

Expect no error to have occurred when cached result
cannot be converted.

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
@scpeters
Copy link
Contributor Author

scpeters commented Oct 2, 2025

Update test expectations to tolerate error

trying again in a30dcc7

@scpeters
Copy link
Contributor Author

scpeters commented Oct 4, 2025

Update test expectations to tolerate error

trying again in a30dcc7

can you approve the workflow to run again?

@scpeters scpeters requested a review from squeed October 9, 2025 14:40
@coveralls
Copy link

Coverage Status

coverage: 63.325%. remained the same
when pulling a30dcc7 on scpeters:invalidcache_delnetwork
into c377947 on containernetworking:main.

@squeed squeed merged commit c5470a9 into containernetworking:main Oct 15, 2025
5 checks passed
@scpeters scpeters deleted the invalidcache_delnetwork branch October 15, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants