ctr-remote: add wildcard support for prefetch-list option #2148
+80
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktock
reviewed
Oct 16, 2025
Comment on lines
190
to
201
| for name := range r.allPaths { | ||
| matched, err := doublestar.Match(pattern, name) | ||
| if err != nil { | ||
| return matchedCount, err | ||
| } | ||
| if !matched { | ||
| continue | ||
| } | ||
| if err := r.Record(name); err != nil { | ||
| continue | ||
| } | ||
| matchedCount++ | ||
| } |
There was a problem hiding this comment.
Could you move this to the optimize.go so that the new dependency isn't added to the root gomod?
Signed-off-by: abushwang <abushwang@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2113 introduced prefetch-list, but it only supports specific filenames. This commit adds wildcard support for the prefetch-list option, allowing users to flexibly select files to prefetch using wildcards.