golangci: disable QF1008 from staticcheck linter #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable: QF1008: could remove embedded field "Generator" from selector Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
klihub
approved these changes
Aug 29, 2025
thaJeztah
reviewed
Aug 29, 2025
| text: "package-comments:" | ||
| - linters: | ||
| - staticcheck | ||
| text: "QF1008:" |
There was a problem hiding this comment.
This can use the "settings" section instead of the string matching; see https://github.com/moby/sys/blob/9dc3a90b82699c54554635f76a6a49757e02c523/.golangci.yml#L14
There was a problem hiding this comment.
Guess what, I tried that. But it's not the same, all != default linters. You cannot state something like
- "defaults"
- "-QF1008"
So I chose the minimal approach, keep using the defaults (whatever they are) and exclude the one problematic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable: