Skip to content

Conversation

@klihub
Copy link
Member

@klihub klihub commented Aug 29, 2025

Revert recent editor-specific addition to .gitignore, and add a comment about favoring global gitignore for such settings.

@klihub
Copy link
Member Author

klihub commented Aug 29, 2025

/cc @ngopalak-redhat Let's revert this. Please use instead a global gitignore for settings specific to your editor of choice.

klihub added 2 commits August 29, 2025 09:36
This reverts commit f578ea2.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub force-pushed the fixes/revert-hasty-gitignore-review branch from 53a93c5 to 02376f3 Compare August 29, 2025 06:36
@ngopalak-redhat
Copy link
Contributor

/lgtm
I didn't know about the global ignore. Thanks.

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry for being nit-picky on this. There's nothing critically wrong with having those ignores, but it can become a bit of a sliding slope and adding extra maintenance burden; and as there's a good alternative for these, it's probably good to prevent that.

LGTM <3

@fuweid
Copy link
Member

fuweid commented Aug 29, 2025

I tried to create repo in github with default Go gitignore.

# If you prefer the allow list template instead of the deny list, see community template:
# https://github.com/github/gitignore/blob/main/community/Golang/Go.AllowList.gitignore
#
# Binaries for programs and plugins
*.exe
*.exe~
*.dll
*.so
*.dylib

# Test binary, built with `go test -c`
*.test

# Code coverage profiles and other test artifacts
*.out
coverage.*
*.coverprofile
profile.cov

# Dependency directories (remove the comment below to include it)
# vendor/

# Go workspace file
go.work
go.work.sum

# env file
.env

# Editor/IDE
# .idea/
# .vscode/

I saw there is commented .idea/. So I merged that original pull request.
I was against such pull request until I saw default gitignore - containerd/containerd#7002
Anyway, revert looks good to me.

@fuweid fuweid merged commit e4518d7 into containerd:main Aug 29, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants