adaptation/builtin: add comment for exported symbols #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
marquiz
force-pushed
the
devel/export-comments-builtin
branch
2 times, most recently
from
1807f89 to
0c7c495
Compare
klihub
approved these changes
Aug 29, 2025
marquiz
force-pushed
the
devel/export-comments-builtin
branch
from
0c7c495 to
1807f89
Compare
|
@marquiz These look fine, but seeing that you have a bunch of these piling up, all of them being basically a bunch of oneliners, and with the common goal of making the repo pass golangci-lint/v2 validation, I think it would save scarce review bandwidth to have all of them (as separate commits) in a single PR. Then you can stack the switch to golangci-lint/v2 as the topmost commit there to put the proof in the pudding. So could you please close them and reopen as a single separate PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (some) errors from golangci-lint v2 (I started to work on that).
Sort of quick'n'dirty, not very high-quality comments, but maybe better than nothing(?)