nit: Add .idea folder to gitignore #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neeraj Krishna Gopalakrishna <ngopalak@redhat.com>
ngopalak-redhat
force-pushed
the
ngopalak/nit_idea_editor
branch
from
3697dc3 to
f578ea2
Compare
klihub
approved these changes
Aug 28, 2025
fuweid
approved these changes
Aug 28, 2025
thaJeztah
reviewed
Aug 28, 2025
| @@ -1 +1,2 @@ | |||
| .idea | |||
There was a problem hiding this comment.
I'd rather not have these in the upstream projects. These are user-specific files to ignore, and it will be a sliding slope to add all ignore rules for all possible editors that users may use.
These generally belong either in your global .gitignore, or can be added to the .git/info/exclude of your checkout.
Perhaps we should add a comment similar to https://github.com/moby/moby/blob/3bee048cbb32f63e45c98210fb15596a0a5e2e62/.gitignore#L1-L3
# If you want to ignore files created by your editor/tools, please consider a
# [global .gitignore](https://help.github.com/articles/ignoring-files).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small nit, but helps a lot when working with goland editor.