chore: clean and unify nolint directives #217
Conversation
It's not. It's like nolint:all (AFAIU). |
|
just needs a dco then.. |
Why I always forget the signoff 😢 Fixed |
pkg/adaptation/api.go
Outdated
| // Aliased request/response/event types for api/api.proto. | ||
| // nolint | ||
| // | ||
| //nolint:all |
There was a problem hiding this comment.
can we actgually mention the linters which complain here? Like
| //nolint:all | |
| //nolint:linter1,linter2 // [explanation why we don't lint] |
There was a problem hiding this comment.
@marquiz @saschagrunert Should we than have here //nolint:revive // [ignore warnings about generated types, names, etc.] here ?
There was a problem hiding this comment.
@saschagrunert agree, I'm all in for this, i.e. only list the linters that actually raise some errors. The original spirit of the PR was only to change the style, not modify any behavior. If we start to do that I'd suggest to remove the unnecessary nolint directives (most of the ones touched here). Thoughts @saschagrunert @klihub ?
There was a problem hiding this comment.
Removing them if they're not required sounds fine to me.
There was a problem hiding this comment.
@saschagrunert agree, I'm all in for this, i.e. only list the linters that actually raise some errors. The original spirit of the PR was only to change the style, not modify any behavior. If we start to do that I'd suggest to remove the unnecessary nolint directives (most of the ones touched here). Thoughts @saschagrunert @klihub ?
@marquiz True, I did not realize that only the one for the {Event,ContainerState}_-block is needed in pkg/adaptation/api.go. And it can be a selective one for revive.
There was a problem hiding this comment.
Thanks for the feedback. I'll adjust the PR accordingly
marquiz
changed the title
Drop unnecessary nolint directives and unify the style of remaining ones to match the rest of the codebase (and the golangci-lint documentation). Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
|
Updated, adjusted commit message accordingly. Only one nolint directive left. |
4 participants
Drop unnecessary nolint directives and unify the style of remaining ones to match the rest of the codebase (and the golangci-lint documentation).