- 
                Notifications
    You must be signed in to change notification settings 
- Fork 83
Bump dependencies #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies #206
Conversation
| @marquiz Unfortunately we can't do this across the board just like that. We are a 'library package' and a direct dependency of cri-o and containerd. If we bump any of our dependency beyond what they have now in main/HEAD, we implictly force them to bump their dependencies, too. And if we want to keep the possibility of updating NRI in still active maintenance branches, then the limitation might be more severe. And many of the deps here try to bump deps beyond what is currently in either of those runtimes main/HEAD. So IMO, at least the lower of the current corresponding deps in cri-o and containerd main/HEAD should be considered to upper bound where we can bump to. If we think we should update some maintenance branches to our next release, then the lowest of the current corresponding deps within those becomes the upper limit. | 
Update outdated deps. Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
| Good point. I changed the main module to bump to the lowest non-CVE-versions. I think plugins can be updated without this limitation... | 
| 
 Yes, definitely. It only applies to core NRI. Plugins can be freely updated to the latest versions. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update outdated deps.