Skip to content

Conversation

@marquiz
Copy link
Contributor

@marquiz marquiz commented Aug 7, 2025

No description provided.

@marquiz marquiz force-pushed the devel/plugin-images-documentation branch from b94abf5 to 07a6ffc Compare August 7, 2025 18:59
@klihub
Copy link
Member

klihub commented Aug 10, 2025

@marquiz Do we plan to add something more verbose here, or is this ready for review now that we have image building merged ?

@marquiz
Copy link
Contributor Author

marquiz commented Aug 11, 2025

Do we plan to add something more verbose here, or is this ready for review now that we have image building merged ?

Yeah, I was planning to add a bit more plugin specific flesh here

@marquiz marquiz force-pushed the devel/plugin-images-documentation branch from 07a6ffc to 99664b3 Compare August 14, 2025 10:26
@marquiz marquiz changed the title [Draft] Add minimal documentation for plugin images Add minimal documentation for plugin images Aug 14, 2025
@marquiz marquiz marked this pull request as ready for review August 14, 2025 10:27
@marquiz
Copy link
Contributor Author

marquiz commented Aug 14, 2025

Ready for review. Aligned with the latest iteration of #197 with separate overlays for stable and unstable images.

@marquiz
Copy link
Contributor Author

marquiz commented Aug 14, 2025

Copy link
Member

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! LGTM.

@klihub klihub requested review from chrishenzie and mikebrow August 14, 2025 10:33
@marquiz
Copy link
Contributor Author

marquiz commented Aug 14, 2025

Let's hold this one until #197 is resolved and merged

@klihub
Copy link
Member

klihub commented Aug 14, 2025

Let's hold this one until #197 is resolved and merged

@marquiz #197 has now been merged.

@marquiz marquiz force-pushed the devel/plugin-images-documentation branch from 99664b3 to c391ae6 Compare August 14, 2025 12:31
Copy link
Member

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@chrishenzie chrishenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
@marquiz marquiz force-pushed the devel/plugin-images-documentation branch from c391ae6 to 43e98ee Compare August 15, 2025 07:01
@marquiz
Copy link
Contributor Author

marquiz commented Aug 15, 2025

Update: Added a disclaimer about the kustomize overlays in the main README

@klihub klihub self-requested a review August 15, 2025 07:07
@klihub klihub merged commit 65eda50 into containerd:main Aug 15, 2025
16 checks passed
@marquiz marquiz deleted the devel/plugin-images-documentation branch August 15, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants