Makefile: build all plugins by default. #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing targets to build network-device-injector and network-logger plugins. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
|
/cc @marquiz |
marquiz
reviewed
Aug 7, 2025
It cannot be built as an external plugin without some minimal additional boilerplate because it is also used as a built-in plugin, directly linked in to the runtime binary. We used to have the necessary boilerplate and a Makefile target to build it as a standalone sample plugin, but it was decided to drop it in the review rounds before merging the validation PR. |
chrishenzie
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing targets to build also the
network-device-injectorandnetwork-loggerplugins.