api,adaptation,generate: allow adjusting linux net devices #157
Conversation
klihub
force-pushed
the
devel/linux-net-devices
branch
from
df6df04 to
02f0b68
Compare
|
❤️ |
klihub
force-pushed
the
devel/linux-net-devices
branch
from
02f0b68 to
d886c51
Compare
klihub
force-pushed
the
devel/linux-net-devices
branch
2 times, most recently
from
df21d77 to
20533ae
Compare
klihub
force-pushed
the
devel/linux-net-devices
branch
from
20533ae to
6e14a15
Compare
|
/cc @aojea @tao12345666333 Here is the draft PR proposal #180 was asking for. |
|
This is fantastic @klihub , can we undraft it for final review |
klihub
force-pushed
the
devel/linux-net-devices
branch
from
6e14a15 to
a03dcca
Compare
We can try to do that to get it reviewed. @mikebrow WDYT? But I think we won't be able to get this merged before the necessary new bits in runtime-spec gets behind a tag. Both CRI-O and containerd main/HEAD is at runtime-spec@v1.2.1 and I think we usually tend to stick to a tagged version in both even in main. |
|
ok, that is fair |
|
Fixes: #180 |
klihub
force-pushed
the
devel/linux-net-devices
branch
from
a03dcca to
a999d9b
Compare
|
Containerd containerd/containerd#12295 is already testing runc 1.4.0-rc.2 |
|
Thx for the update @aojea |
klihub
force-pushed
the
devel/linux-net-devices
branch
from
a999d9b to
8df6cec
Compare
Point opencontainers/runtime-spec to a (yet untagged) version with support for linux net device injection. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
We still have support for the deprecated OCI Prestart hook. Add ignore rule for the related linting error. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Allow adding and removing container linux net devices. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
devel/linux-net-devices
branch
from
8df6cec to
0a96043
Compare
@aojea @mikebrow But I think we'd still need a tagged version of |
|
@klihub yeah, I was using the comment as a breadcrumb , so next time I check I can track teh history, otherwise I forget I was not trying to push for merging before that, sorry for the confusion |
@aojea No prob / no offense taken. I just asked to make sure I understand correctly where we are and whether we can try to move this forward yet. |
|
informational update , ETA for 1.3.0 spec is 2025/11/04 opencontainers/runc#4875 (comment) , runc will follow |
3 participants
Allow plugins to adjust linux net devices.
Notes:
This PR is marked a draft since it uses an untagged opencontainers/runtime-spec version v1.2.2-0.20250401095657-e935f995dd67. Once a new version is tagged, we can mark this PR ready for review. Testing this requires
runcwith support forLinuxNetDeviceinjection, @aojea has a pending PR