add support for the new --estargz-gzip-helper option in stargz-snapshotter #4543
+83
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktock
reviewed
Oct 18, 2025
Comment on lines
+25
to
+27
| github.com/containerd/stargz-snapshotter v0.18.0 //gomodjail:unconfined | ||
| github.com/containerd/stargz-snapshotter/estargz v0.18.0 //gomodjail:unconfined | ||
| github.com/containerd/stargz-snapshotter/ipfs v0.18.0 //gomodjail:unconfined |
There was a problem hiding this comment.
Could you separate commits to the bumping up and the addition of the new flag?
go.mod
Outdated
Comment on lines
151
to
152
| require go.yaml.in/yaml/v2 v2.4.2 // indirect | ||
|
|
There was a problem hiding this comment.
Why does this have a separated require?
There was a problem hiding this comment.
After updating dependencies, go mod tidy automatically added this. I’ve moved it to indirect require manually and future runs of go mod tidy won’t add a separate require entry.
escapefreeg
force-pushed
the
main
branch
2 times, most recently
from
1317cd1 to
28ee111
Compare
escapefreeg
force-pushed
the
main
branch
2 times, most recently
from
68268a9 to
4eef4f7
Compare
added 2 commits
October 21, 2025 20:24
Signed-off-by: clarehkli <clarehkli@tencent.com>
…otter add support for the newly added image conversion --estargz-gzip-helper option in stargz-snapshotter Signed-off-by: clarehkli <clarehkli@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump github.com/containerd/stargz-snapshotter from v0.17.0 to v0.18.0 and add support for the new image conversion option --estargz-gzip-helper