initial draft oft hold_max with heuristic #657
Conversation
|
this is now ready for some feedback @djc |
|
would love some feedback on this |
djugei
force-pushed
the
heuristic
branch
5 times, most recently
from
e72c3c9 to
d0715e4
Compare
|
can i get some feedback on this? |
|
rebased to 1.18 |
src/iter.rs
Outdated
| @@ -57,11 +57,97 @@ where | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Debug)] | |||
| struct RingBuf<const SIZE: usize = 10> { | |||
There was a problem hiding this comment.
It doesn't seem like making SIZE a generic const is helpful since we're not actually using that in this project?
There was a problem hiding this comment.
yeah that was to make playing with different sizes easier for me, i can take it out in the final commit.
There was a problem hiding this comment.
i think i will be keeping this, as i want to avoid magic numbers.
will do before a merge, i am keeping it in separate commits for now to make reviews easier (for example its somewhat easier to ignore the code movements by just not looking at that commit etc) i will make the requested changes over the weekend probably |
djugei
force-pushed
the
heuristic
branch
2 times, most recently
from
bb9ce0d to
b408abb
Compare
On the first seek it gets enabled, displaying the progress as the max of the last 10 updates. If there ever are more than 5 consecutive reads and writes without seek it gets disabled again, keeping the performance impact low.
|
I have done all(-1) of the requested changes, also split out the bug fix into a separate commit while squashing all other changes. |
alternative or update to #642
In BufRead/AsyncBufRead fill_buf does not logically consume the reader/advance progress, only a call to consume does. this was the wrong way around for the AsyncBufRead implementation, i have fixed that in this pr.