Add support for context values #521
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What's left: - More testing - Figuring out an initial reactivity model Signed-off-by: Paul Sachs <psachs@buf.build>
To be added in it's own PR Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
Signed-off-by: Paul Sachs <psachs@buf.build>
|
Closing this for now. Passing context values in a dynamic way has a number of ways that are unpredictable. If you need to set context values, create a custom transport with an interceptor that sets the value and use addStaticKeyToTransport to bind that context value to a query. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds passing through a serializable version of context values. Note that this does not provide a way to create a reactive version of context values, and just provides the building blocks in order to allow passing context values to the underlying RPCs and ensuring that the context values can be serialized in a way to allow a reactive version.
Fixes #516