Replace jest with vitest #421
Conversation
Includes all linting changes, helper methods and config files. Signed-off-by: Paul Sachs <psachs@buf.build>
paul-sachs
force-pushed
the
psachs/vitest-again
branch
from
747c3ac to
8b03a44
Compare
| // https://vitejs.dev/config/ | ||
| export default defineConfig({ | ||
| test: { | ||
| environment: "jsdom", |
There was a problem hiding this comment.
Wow, did jest simply fix their environment?
There was a problem hiding this comment.
jest did so much stuff automatically. Eventually, we might take advantage of vitest's browser mode to actually run in the browser (like jasmine... software development is just a circle) and we can stop patching the dom, but for our purposes, this is fine.
There was a problem hiding this comment.
jest-environment-jsdom provides a DOM so that tests for web apps can run on Node.js. Awesome.
Unfortunately, it also removes the text encoding API from globals, which Node.js has been supporting for many years now. The problem is so bad that it forced us to create @bufbuild/jest-environment-jsdom. It's a simple fix, but Jest has been sitting the problem out for years now, blaming jsdom.
Vitest does the same thing with environments, but it fixes the problem (see link above). Kudos to Vitest.
There was a problem hiding this comment.
Ah I understand what you meant now
Includes all linting changes, helper methods and config files.
This change cleans up a bunch of config and removes some warnings as well. Fixes #412