EdDSA: update handling to allow other providers #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruton
force-pushed
the
eddsa-provider
branch
3 times, most recently
from
6d40ee8 to
6c8028e
Compare
Allow keys from other providers by implementing engineTranslateKey. This will hopefully allow us to handle the new Android implementation without inspecting it deeply.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 797e9fd and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 42.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 42.6% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow keys from other providers by implementing engineTranslateKey. This will hopefully allow us to handle the new Android implementation without inspecting it deeply.
Part of the fix for connectbot/connectbot#1483