Skip to content

Enable DescribeConsumerGroup test #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PratRanj07
Copy link
Contributor

Enable DescribeConsumerGroup tests for Consumer Protocol

@Copilot Copilot AI review requested due to automatic review settings June 30, 2025 11:10
@PratRanj07 PratRanj07 requested review from a team as code owners June 30, 2025 11:10
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the DescribeConsumerGroup tests under both classic and new consumer protocols by configuring broker timeouts and extending the test helper to verify group type.

  • Added low session and heartbeat timeout settings in the KRaft server properties to ensure timely test behavior.
  • Extended checkGroupDesc to accept and validate a ConsumerGroupType and updated all test calls accordingly.
  • Removed the skip guard so the tests run regardless of the protocol, with logic to adapt expectations based on runtime protocol support.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
kafka/testresources/kraft/server.properties Configure group session and heartbeat timeouts for test brokers
kafka/integration_test.go Add groupType parameter to checkGroupDesc, update calls, and remove skip
Comments suppressed due to low confidence (2)

kafka/integration_test.go:105

  • Parameter name 'group_type' uses snake_case; Go convention recommends using camelCase (e.g., 'groupType').
	group_type ConsumerGroupType, group string,

kafka/integration_test.go:101

  • [nitpick] Update this comment to mention the newly added 'groupType' parameter so the documentation stays in sync with the function signature.
// checkGroupDesc is a helper function to check the validity of a ConsumerGroupDescription.

@@ -27,3 +27,7 @@ listener.security.protocol.map=PLAINTEXT:PLAINTEXT,SSL:SSL,SASL_PLAINTEXT:SASL_P
authorizer.class.name=org.apache.kafka.metadata.authorizer.StandardAuthorizer
sasl.enabled.mechanisms=PLAIN
controller.quorum.voters=0@kafka:38705
group.consumer.min.session.timeout.ms=5000
group.consumer.session.timeout.ms=5000
Copy link
Preview

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing whitespace at the end of this line to prevent potential parsing issues in configuration loading.

Suggested change
group.consumer.session.timeout.ms=5000
group.consumer.session.timeout.ms=5000

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant