Skip to content

Allow custom config fetcher + include CF ray ID #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

adams85
Copy link
Collaborator

@adams85 adams85 commented May 10, 2025

Describe the purpose of your pull request

Adds a new option named configFetcher, which allows consumers to choose the config fetcher implementation to use or to provide their own implementation (useful for testing primarily).

Plus, makes sure that Cloudflare Ray ID is included into log messages when the HTTP response is not successful. (We'll need some further CORS configuration to make this work in browser targets).

Also,

  • corrects the API surface area of the main entry point,
  • fixes a few minor bugs.

Related issues (only if applicable)

https://trello.com/c/Fdzvind3
https://trello.com/c/iCm8OlJv

How to test? (only if applicable)

n/a

Security (only if applicable)

n/a

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@adams85 adams85 force-pushed the feature/custom-config-fetcher branch from 096a071 to c625483 Compare May 10, 2025 10:59
@adams85 adams85 force-pushed the feature/custom-config-fetcher branch from c625483 to be519b2 Compare May 10, 2025 11:13
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
73.8% Coverage on New Code (required ≥ 80%)
4.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant