Skip to content

Error reporting improvements #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adams85
Copy link
Collaborator

@adams85 adams85 commented May 8, 2025

Describe the purpose of your pull request

Define error codes (EvaluationErrorCode, RefreshErrorCode) and expose them to the user (EvaluationDetails.errorCode, RefreshResult.errorCode) so they can reliably identify the error type without resorting to guess it by checking the error message (see also: open-feature/dotnet-sdk-contrib#119 (comment))

Also,

  • fixes a minor bug in setting type mismatch check (type mismatch should also be reported for allowed flag override values),
  • fixes a minor bug in formatting errors (some JS runtimes doesn't include the error message in the stack trace),
  • fixes a minor bug in FetchError (name property should be set to the class name).

Related issues (only if applicable)

https://trello.com/c/mU63054x

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

adams85 added 2 commits May 8, 2025 12:45
…pose them to the user (IEvaluationDetails.errorCode)
…and expose them to the user (RefreshResult.errorCode)
Copy link

sonarqubecloud bot commented May 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant