-
Notifications
You must be signed in to change notification settings - Fork 18
Docs review integrations #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Head's up @configcat/text-reviewers - someone needs a text review! |
Deploying configcat-docs with
|
Latest commit: |
5b695e4
|
Status: | ✅ Deploy successful! |
Preview URL: | https://af828324.docs-xmy.pages.dev |
Branch Preview URL: | https://docs-review-integrations.docs-xmy.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, according to the new text guidelines, text quoted from the UI should be bold. This style
is reserved for code-like text.
The guidelines are not in effect yet, so I'd rather not block the PR with this. But it would be nice to change the text formatting sooner or later to match it.
2. Navigate to `App Connections` from the side menu. | ||
3. Click on `Add connection` and search for `ConfigCat` in the `Add new connection` dialog. | ||
4. Click on `Add connection` button to connect ConfigCat. | ||
5. Generate a Public API credential at <a href="https://app.configcat.com/my-account/public-api-credentials" target="_blank">ConfigCat Dashboard</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5. Generate a Public API credential at <a href="https://app.configcat.com/my-account/public-api-credentials" target="_blank">ConfigCat Dashboard</a>. | |
5. Generate a Public Management API credential at <a href="https://app.configcat.com/my-account/public-api-credentials" target="_blank">ConfigCat Dashboard</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, maybe it would be better to use the same line from other docs:
5. Get your ConfigCat Public API credentials from ConfigCat Dashboard/Public Management API credentials.
1. Create a new Trigger. | ||
1. Select `ConfigCat` app, `Feature Flag & Setting value changed` as Trigger event and the connected account. | ||
1. Select the Product in which you want to get notified about the Feature Flag or Setting value changes. | ||
1. Select optionally Config and/or Environment to specify more of the notification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Select optionally Config and/or Environment to specify more of the notification."
What does this mean? Is this selection some kind of filter for the notifications?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Basically, there are 3 selects. Product is required. The Config and Environment are optional and make the notification more specific.
Maybe it should look like this:
- Select the Product in which you want to get notified about the Feature Flag or Setting value changes.
1.1 To specify the notification more, select Config and/or Environment.
:::info | ||
You may have to connect the Zoho Flow Slack app to your Slack subscription if you didn't do it before. | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Co-authored-by: adams85 <31276480+adams85@users.noreply.github.com>
Co-authored-by: adams85 <31276480+adams85@users.noreply.github.com>
Co-authored-by: adams85 <31276480+adams85@users.noreply.github.com>
Co-authored-by: adams85 <31276480+adams85@users.noreply.github.com>
Co-authored-by: adams85 <31276480+adams85@users.noreply.github.com>
Co-authored-by: adams85 <31276480+adams85@users.noreply.github.com>
Describe the purpose of your pull request
Review and update the following docs:
Requirement checklist