Skip to content

Add: Zombie Flags Report Documentation #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Jun 3, 2025

Conversation

codedbychavez
Copy link
Contributor

@codedbychavez codedbychavez commented Apr 3, 2025

Describe the purpose of your pull request

  • Add: Zombie Flags documentation to the docs.

Related issues (only if applicable)

How to test? (only if applicable)

What part of the application was affected by the changes?

  • A new page titled Zombie Flags was added under the Guides section in the Docs.
  • Add link in website/src/pages/index.js

What should be tested?

  • Check if the newly added page is ok. Feel free to leave any feedback.

Requirement checklist

  • I have validated my changes on a test/local environment.
  • I have tested that the code snippets I added work. (Leave unchecked if there are no new code snippets.)
  • I have added my changes to the V1 and V2 documentations.

@codedbychavez codedbychavez marked this pull request as ready for review April 3, 2025 18:48
@codedbychavez codedbychavez requested a review from a team as a code owner April 3, 2025 18:48
Copy link

cloudflare-workers-and-pages bot commented Apr 7, 2025

Deploying configcat-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 330879d
Status: ✅  Deploy successful!
Preview URL: https://f590e7b9.docs-xmy.pages.dev
Branch Preview URL: https://add-zombie-flags-report-docu.docs-xmy.pages.dev

View logs

codedbychavez and others added 8 commits April 17, 2025 11:27
Co-authored-by: aisz0811 <55664408+aisz0811@users.noreply.github.com>
Co-authored-by: aisz0811 <55664408+aisz0811@users.noreply.github.com>
Applied first batch of suggetsions

Co-authored-by: aisz0811 <55664408+aisz0811@users.noreply.github.com>
Co-authored-by: aisz0811 <55664408+aisz0811@users.noreply.github.com>
Co-authored-by: Csilla Kisfaludi <55664408+aisz0811@users.noreply.github.com>
codedbychavez and others added 2 commits May 12, 2025 09:21
Co-authored-by: Csilla Kisfaludi <55664408+aisz0811@users.noreply.github.com>
@codedbychavez codedbychavez requested a review from aisz0811 May 13, 2025 20:49
@codedbychavez
Copy link
Contributor Author

Hi @aisz0811

The updates are in.

Copy link
Member

@laliconfigcat laliconfigcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please create the v1 versioned docs too?

Other than the minor comments, I loved it, thank you very much!!!

@codedbychavez
Copy link
Contributor Author

Could you please create the v1 versioned docs too?

Other than the minor comments, I loved it, thank you very much!!!

Most welcome! happy to help 😁

@codedbychavez
Copy link
Contributor Author

Hi @laliconfigcat

Thanks a lot for the suggestions and feedback 🙏. I made the improvements 🚀

Let me know if its better now.

laliconfigcat
laliconfigcat previously approved these changes May 30, 2025
Copy link
Member

@laliconfigcat laliconfigcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thank you very much!
Please don't merge the PR yet. I'll merge it before we release the features to live (I expect it early next week).

@codedbychavez
Copy link
Contributor Author

Awesome work! Thank you very much! Please don't merge the PR yet. I'll merge it before we release the features to live (I expect it early next week).

Noted, most welcome. Added the do not merge yet label.

Co-authored-by: Csilla Kisfaludi <55664408+aisz0811@users.noreply.github.com>
laliconfigcat and others added 2 commits June 3, 2025 11:48
Co-authored-by: Csilla Kisfaludi <55664408+aisz0811@users.noreply.github.com>
@laliconfigcat laliconfigcat merged commit 9681236 into master Jun 3, 2025
3 checks passed
@laliconfigcat laliconfigcat deleted the add-zombie-flags-report-documentation branch June 3, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants