Skip to content

Conversation

@kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Oct 13, 2025

Removed inconsistencies and parred down the code to only the necessary pieces:

  • Removed goatcounter_dashboard_url in favor of goatcounter_url
  • Remove custom icon_links.html template and instead inject Zulip & Discord links into the icon_links list
  • Replace zulip_logo.svg with FontAwesome custom glyph:
    old new
    Screenshot 2025-10-14 at 01 03 48 Screenshot 2025-10-14 at 01 03 35
  • Remove unused get_html_theme_path function (see Remove unused function #31)
  • Remove layout.html since its identical to the layout provided by pydata-sphinx-theme (see Remove custom layout.html and add pydata-sphinx-theme=0.16 support #30)
  • Override theme-version.html template to reference the correct theme name
  • Add sphinx-autobuild & make livehtml for easier local testing (see Add make livehtml #29)
  • Standardize the author to Anaconda, Inc. (reverted)

Happy to split this into smaller PRs if desired.

@kenodegard kenodegard changed the title Aggregate all defaults into set_config_defaults Improved default handling Oct 13, 2025
@kenodegard kenodegard marked this pull request as ready for review October 13, 2025 23:16
Copy link
Contributor

@travishathaway travishathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this closer today and tested it out with the conda docs site. Unfortunately, there are actually some key differences between the layout.html in the pydata-sphinx-theme and the layout.html in this repository.

You can see how it breaks our navigation in the screenshot (it's not there).

These are the specific lines that differ that make everything work:

pydata-sphinx-theme: https://github.com/pydata/pydata-sphinx-theme/blob/4704de40b2f10806dc67428882bdd143b540808f/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html#L89-L91

conda-sphinx-theme:

{% if sidebar_nav_html | length == 0 %}
{% set sidebars = sidebars | reject("in", "sidebar-nav-bs.html") | list %}
{% endif %}

It has to do with how the "sidebars" variable is being set in the template (I think 🤔).

Image

@kenodegard
Copy link
Contributor Author

@travishathaway ah I see, I dug a little more and I think I found an alternative: #30

@travishathaway travishathaway self-requested a review October 15, 2025 11:01
@kenodegard kenodegard marked this pull request as draft October 15, 2025 12:27
@kenodegard kenodegard mentioned this pull request Oct 15, 2025
@codecov
Copy link

codecov bot commented Oct 27, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@kenodegard kenodegard marked this pull request as ready for review October 27, 2025 18:28
@kenodegard kenodegard requested a review from jezdez October 27, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants