-
Notifications
You must be signed in to change notification settings - Fork 3
Improved default handling #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at this closer today and tested it out with the conda docs site. Unfortunately, there are actually some key differences between the layout.html in the pydata-sphinx-theme and the layout.html in this repository.
You can see how it breaks our navigation in the screenshot (it's not there).
These are the specific lines that differ that make everything work:
pydata-sphinx-theme: https://github.com/pydata/pydata-sphinx-theme/blob/4704de40b2f10806dc67428882bdd143b540808f/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html#L89-L91
conda-sphinx-theme:
conda-sphinx-theme/conda_sphinx_theme/layout.html
Lines 20 to 22 in 3026852
| {% if sidebar_nav_html | length == 0 %} | |
| {% set sidebars = sidebars | reject("in", "sidebar-nav-bs.html") | list %} | |
| {% endif %} |
It has to do with how the "sidebars" variable is being set in the template (I think 🤔).
|
@travishathaway ah I see, I dug a little more and I think I found an alternative: #30 |
2f129c4 to
e035571
Compare
These are testing sphinx itself which isn't something we need to worry about. We should assume theme_options is always present.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Removed inconsistencies and parred down the code to only the necessary pieces:
goatcounter_dashboard_urlin favor ofgoatcounter_urlicon_links.htmltemplate and instead inject Zulip & Discord links into theicon_linkslistzulip_logo.svgwith FontAwesome custom glyph:Remove unused(see Remove unused function #31)get_html_theme_pathfunctionRemove(see Remove customlayout.htmlsince its identical to the layout provided bypydata-sphinx-themelayout.htmland addpydata-sphinx-theme=0.16support #30)theme-version.htmltemplate to reference the correct theme nameAdd(see Addsphinx-autobuild&make livehtmlfor easier local testingmake livehtml#29)Standardize the author to(reverted)Anaconda, Inc.Happy to split this into smaller PRs if desired.