Skip to content

fix: goreleaser issues #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nalum
Copy link
Contributor

@nalum nalum commented May 19, 2025

  • Removing the github.com segment from the URLs as this is not meant to be there.
  • upgrade the tinygo version

@nalum nalum changed the title Fix container image templates fix: container image templates May 19, 2025
@nalum nalum force-pushed the goreleaser-config branch 2 times, most recently from 11b718d to 605cfda Compare May 19, 2025 07:26
@nalum nalum changed the title fix: container image templates fix: goreleaser issues May 19, 2025
@nalum nalum force-pushed the goreleaser-config branch 4 times, most recently from 02a3de8 to 20b7df5 Compare May 19, 2025 08:56
@nalum nalum force-pushed the goreleaser-config branch from 20b7df5 to 95baf31 Compare May 19, 2025 09:01
@cedi
Copy link
Member

cedi commented May 20, 2025

Hi @nalum ,

Thanks for the contribution!
I think your work is already covered by #57 and bumping the tinygo version specifically is done in #58

It’s only waiting on @xvzf to review (and merge) those PRs

@nalum
Copy link
Contributor Author

nalum commented May 20, 2025

@nalum
Copy link
Contributor Author

nalum commented May 20, 2025

It looks like #58 is built on top of #57 (?) could we merge my change and close #58 and then rebase #57?

I also don't mind undoing the tinygo update.

@xvzf
Copy link
Member

xvzf commented May 24, 2025

I've included your in here: #61

thx for the contribution and sorry for the delays!

@xvzf xvzf closed this in #61 May 24, 2025
@nalum nalum deleted the goreleaser-config branch May 24, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants