Skip to content

feat(OpenTelemetry): Integrate OpenTelemetry into agent #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

cedi
Copy link
Member

@cedi cedi commented May 9, 2025

  • integrate OpenTelemetry logging with zap logger for better observability
  • add OpenTelemetry gRPC middleware for enhanced tracing capabilities
  • document new OTLP exporter endpoint for better configuration guidance

Note: Must be merged after #54

cedi added 2 commits May 12, 2025 00:07
- integrate OpenTelemetry logging with zap logger for better observability
- add OpenTelemetry gRPC middleware for enhanced tracing capabilities
- document new OTLP exporter endpoint for better configuration guidance
@xvzf xvzf force-pushed the feature/addOpenTelemetry branch from d856821 to 6be895a Compare May 11, 2025 22:07
Copy link
Member

@xvzf xvzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one! Really like it!

There's one blocker (go version bump which is incompatible with the tinygo version); I'll test it during the next days on actual hardware before merging it

github-actions bot and others added 11 commits May 12, 2025 00:15
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* refactor(workflows): Improve GitHub Action workflows

* bump go version to 1.24

* set coverage report baseline to correct workflow

* nit: keep same

* require older go version

* let semantic-prs write to PR

* let semantic-prs write to PR

* bump go version to 1.24

* bump dependencies

---------

Co-authored-by: Cedric Kienzler <cedric@specht-labs.de>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: set goreleaser version to v2.x

Signed-off-by: Matthias Riegler <me@xvzf.tech>

* fix: goreleaser issues

---------

Signed-off-by: Matthias Riegler <me@xvzf.tech>
Co-authored-by: Luke Mallon (Nalum) <luke@mallon.ie>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…metry

Signed-off-by: Matthias Riegler <me@xvzf.tech>
@cedi
Copy link
Member Author

cedi commented May 25, 2025

I am pretty confident the issue of the Coverage report comment is due to permission issues / the way the GitHub Org / Repo is configured.

The workflow requests the correct permissions:

    permissions:
      contents:      read
      actions:       read
      pull-requests: write
      statuses:      write

and I suspect that somewhere in the Repos or Org settings the GitHub Actions are missing a flag that prohibits the write permissions.

@xvzf What's your take? I have confirmed the workflow should work in my fork. Do we wannna merge this and resolve permission issues async?

@cedi cedi force-pushed the main branch 14 times, most recently from 9ee78e1 to 104f709 Compare June 6, 2025 13:47
@cedi cedi force-pushed the main branch 4 times, most recently from 71bd6af to f6a70fa Compare June 6, 2025 16:28
@cedi
Copy link
Member Author

cedi commented Jun 6, 2025

superseded by #90

@cedi cedi closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants