-
Notifications
You must be signed in to change notification settings - Fork 3
background mask option for pseudo labeler - unsupervised training #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stmartineau99
wants to merge
12
commits into
computational-cell-analytics:main
Choose a base branch
from
stmartineau99:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
background mask option for pseudo labeler - unsupervised training #135
stmartineau99
wants to merge
12
commits into
computational-cell-analytics:main
from
stmartineau99:main
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good now! The only things to address:
- You are not actually using the new class for the mean teacher trainer.
- Some cosmetics.
See details in the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewPseudoLabeler
to subtract background from the pseudo labels if a background mask is givenget_unsupervised_loader
to handle 4 cases:get_unsupervised_loader
handles each case correctly:DropChannel
,ChannelWiseRawTransform
,ChannelWiseAugmentations
mean_teacher_adaptation
to use theNewPseudoLabeler
if the background mask is givenNewMeanTeacherTrainer
, which drops the background mask from the teacher input after computing pseudo labels. it also drops the background mask from the student input since this is not used. This behavior only occurs when it recieves training data, and not for validation.NewPseudoLabeler
so that it behaves correctly when it recieves training and validation data, since in the case of validation there is no background mask channel.