-
Notifications
You must be signed in to change notification settings - Fork 1
Feat: districts
Django app setup
#91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
543c7a5
to
b702236
Compare
district
Django app setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nitpick, I think the name of the app districts
(plural) reads a little better than the singular district
.
E.g. thinking about the URL structure, we'll want something like /districts/<id>
-- not that this ties exactly to the app name, but the consistency seems good.
Thoughts?
No, this is a good suggestion. I'm actually seeing this pattern in the Miro board, but I don't know why I overlooked it ( |
b702236
to
5acbd72
Compare
district
Django app setupdistricts
Django app setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Nice to have a fixtures file with all the Districts defined to get started with.
Closes #63
Part of #65
This PR sets up the
districts
Django app and adds an initial District model (with associated fixtures).Notes
We assume these patterns
models.py
module per Django app.migrations
folder per Django app (python manage.py makemigrations
will run through each app and make the migrations). This means that inmakemigrations.sh
we will have several lines likepython -m black pems/district/migrations/*.py
, one per app.local_fixtures.json
file in the root Django project .