-
Notifications
You must be signed in to change notification settings - Fork 1
Feat: use PostgreSQL for the database backend #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lalver1
wants to merge
9
commits into
main
Choose a base branch
from
feat/django-postgres-db
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
354f0f4
feat(compose): add postgres and pgweb services
lalver1 9d70d3f
refactor(settings): use postgres backend
lalver1 ed38802
feat(commands): add management command for database setup
lalver1 7288a6b
chore(commands): remove redundant database setup commands
lalver1 efaa9a6
feat(compose): ensure postgres server is ready
lalver1 bfc4663
feat(database): add Aurora Serverless storage and configuration
lalver1 332fb4a
fix(compose): remove pgweb container_name to avoid conflict
lalver1 fc0c42e
fix(database): Aurora Serverless setup and configuration
lalver1 721edc3
refactor(tests): use CBV testing approach for DistrictView test
lalver1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you grabbed this as-is from the CDRC work, but I realized there's a conflict.
If both projects have this
container_name
attribute, then the second one fails to come up:If I remove this line, it comes up just fine. I'll make a ticket to remove it from CDRC as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing this! Removed it in 332fb4a