Skip to content

Revert https://github.com/compiler-research/xeus-cpp/pull/349 (keeping test) #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

Fixes # (issue)

Currently CppInterOps Emscripten ci is broken to #349 for MacOS arm for llvm, as can be seen here https://github.com/compiler-research/CppInterOp/actions/runs/15633230695 .
The test itself passes in these circumstances with the old get_stdopt as can be seen here compiler-research/CppInterOp#632 . Therefore this PR suggests reverting get_stdopt while keeping the test

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (e0946f7) to head (d71d29c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   81.81%   82.10%   +0.28%     
==========================================
  Files          20       20              
  Lines         957      950       -7     
  Branches       89       87       -2     
==========================================
- Hits          783      780       -3     
+ Misses        174      170       -4     
Files with missing lines Coverage Δ
src/xinterpreter.cpp 90.10% <100.00%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes

Files with missing lines Coverage Δ
src/xinterpreter.cpp 90.10% <100.00%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anutosh491
Copy link
Collaborator

anutosh491 commented Jun 13, 2025

Hi, please wait before taking this in. The solution proposed by the Pr I made shouldn't be fundamentally wrong. There might be something deeper here.

We should make a note of what creates the difference if there is one.

Edit: also would be great if could you paste the exact line in the CI where the test fails ? I haven't seen the doctest failure if there's a test failing.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay as we need the jupyterlite deployment to work perfectly (as we're nearing the submission of the blog, I need the build and deploy CI to run)

Hence let's go ahead with this and debug whatever later.

Though we need to keep track of the improvements here and use the configure_request_impl through xeus https://xeus.readthedocs.io/en/latest/kernel_implementation.html#configurationa
for any operation before the first execute request .

@anutosh491 anutosh491 merged commit 5f41b15 into compiler-research:main Jun 14, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants